dajac commented on code in PR #12337:
URL: https://github.com/apache/kafka/pull/12337#discussion_r906655583
##########
clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsOptions.java:
##########
@@ -44,10 +45,21 @@ public ListConsumerGroupOffsetsOptions
topicPartitions(List<TopicPartition> topi
return this;
}
+ /**
+ * Sets an optional requireStable flag.
+ */
+ public void requireStable(final boolean requireStable) {
Review Comment:
Do we need a KIP for this change?
##########
clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java:
##########
@@ -40,16 +40,27 @@ public class ListConsumerGroupOffsetsHandler extends
AdminApiHandler.Batched<Coo
private final CoordinatorKey groupId;
private final List<TopicPartition> partitions;
+ private final boolean requireStable;
private final Logger log;
private final AdminApiLookupStrategy<CoordinatorKey> lookupStrategy;
+ public ListConsumerGroupOffsetsHandler(
+ String groupId,
Review Comment:
nit: Indentation seems to be off in comparison to the other
constructor/methods.
##########
clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsOptions.java:
##########
@@ -44,10 +45,21 @@ public ListConsumerGroupOffsetsOptions
topicPartitions(List<TopicPartition> topi
return this;
}
+ /**
+ * Sets an optional requireStable flag.
+ */
+ public void requireStable(final boolean requireStable) {
+ this.requireStable = requireStable;
+ }
+
/**
* Returns a list of topic partitions to add as part of the result.
*/
public List<TopicPartition> topicPartitions() {
return topicPartitions;
}
+
+ public boolean shouldRequireStable() {
Review Comment:
nit: `requireStable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
