epugh commented on code in PR #4513:
URL: https://github.com/apache/solr/pull/4513#discussion_r3391083692
##########
solr/core/src/java/org/apache/solr/cli/StreamTool.java:
##########
@@ -310,16 +312,8 @@ private PushBackStream doRemoteMode(CommandLine cli,
String expr) throws Excepti
"The stdin() expression is only usable with --worker local set up.");
}
- final SolrStream solrStream =
- new SolrStream(solrUrl + "/solr/" + collection, params("qt",
"/stream", "expr", expr));
-
- String credentials =
cli.getOptionValue(CommonCLIOptions.CREDENTIALS_OPTION);
- if (credentials != null) {
- String username = credentials.split(":")[0];
- String password = credentials.split(":")[1];
- solrStream.setCredentials(username, password);
- }
- return new PushBackStream(solrStream);
+ return new PushBackStream(
+ new SolrStream(solrUrl + "/solr/" + collection, params("qt",
"/stream", "expr", expr)));
Review Comment:
i feel like this should be `"/solr/" + collection + "/stream",
params("expr",expr)`... but that is a bigger change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
