epugh commented on code in PR #4513:
URL: https://github.com/apache/solr/pull/4513#discussion_r3381422752
##########
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##########
@@ -180,7 +180,7 @@ public static SolrClient getSolrClient(CommandLine cli)
throws Exception {
* is used, and warns those users. In the future we'll have urls ending with
/api as well.
*
* @param solrUrl The user supplied url to Solr.
- * @return the solrUrl in the format that Solr expects to see internally.
+ * @return a URL without any path, e.g. {@code http://localhost:8983}
*/
public static String normalizeSolrUrl(String solrUrl) {
Review Comment:
I think a little bit dinosaur... But not a lot dinosaur... We've been
trying to simpliy users lives so they don't have to think about /solr or /v2 or
/api all the time, unless is critical. So, we normalize to the root version,
and then whatever tool can append what it needs...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
