dsmiley commented on code in PR #4513:
URL: https://github.com/apache/solr/pull/4513#discussion_r3382037359
##########
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##########
@@ -180,7 +180,7 @@ public static SolrClient getSolrClient(CommandLine cli)
throws Exception {
* is used, and warns those users. In the future we'll have urls ending with
/api as well.
*
* @param solrUrl The user supplied url to Solr.
- * @return the solrUrl in the format that Solr expects to see internally.
+ * @return a URL without any path, e.g. {@code http://localhost:8983}
*/
public static String normalizeSolrUrl(String solrUrl) {
Review Comment:
IMO URL utility methods should be centralized to URLUtil. And naming
reconsidered. If this method produces URLs without any path, then this is an
_opportunity_ to very simply state that in the method name rather than
ambiguous "normalization", (it once wasn't ambiguous but in our transition
period, is ambiguous).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
