dsmiley commented on code in PR #3988:
URL: https://github.com/apache/solr/pull/3988#discussion_r2654717093
##########
solr/core/src/test/org/apache/solr/handler/V2StandaloneTest.java:
##########
@@ -35,7 +34,6 @@ public void testWelcomeMessage() throws Exception {
Path solrHomeTmp = createTempDir();
PathUtils.copyDirectory(
TEST_HOME().resolve("configsets/minimal/conf"),
solrHomeTmp.resolve("conf"));
- Files.copy(TEST_HOME().resolve("solr.xml"),
solrHomeTmp.resolve("solr.xml"));
Review Comment:
I think it's a bit irresponsible to do this on the grounds that tests pass,
without looking into the matter any further. Take a look at
`solr/core/src/test-files/solr/solr.xml`. There are comments there about why
the settings are different (e.g. distribUpdateSoTimeout) and various
customizability that (unfortunately) our standard solr.xml doesn't have (but
should).
I can see that the current situation could use improvement. Probably a
separate PR should tackle that. Maybe that solr.xml should be in the
solr-test-framework JAR as a resource that the test infra can reference and be
used by 3rd parties. But also need a simple one-liner to install it into
provided Path dir. Or alternatively a new property to the node props which
contains a path to where solr.xml is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
