dsmiley commented on code in PR #3988:
URL: https://github.com/apache/solr/pull/3988#discussion_r2659293034
##########
solr/core/src/test/org/apache/solr/security/BasicAuthStandaloneTest.java:
##########
@@ -54,8 +53,6 @@ public class BasicAuthStandaloneTest extends SolrTestCaseJ4 {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
private static final Path ROOT_DIR = TEST_HOME();
- private static final Path CONF_DIR =
- ROOT_DIR.resolve("configsets").resolve("configset-2").resolve("conf");
Review Comment:
I looked into the history of configset2 when I wrote my comment. I see it
as a general addition for something simple. It has a bad name! Other tests
now use it too. I didn't see it as a configset that was designed fundamentally
and only for TestConfigSets. Maybe I overlooked something... why do you think
it's only suitable for that test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
