dsmiley commented on code in PR #3988:
URL: https://github.com/apache/solr/pull/3988#discussion_r2653173808
##########
solr/core/src/test/org/apache/solr/handler/TestReplicationHandlerDiskOverFlow.java:
##########
@@ -114,6 +116,7 @@ public void tearDown() throws Exception {
followerClient = null;
}
System.clearProperty(TEST_URL_ALLOW_LIST);
+ System.clearProperty("solr.security.allow.urls.enabled");
Review Comment:
Clearing properties in an `@After` or `@AfterClass` is always pointless
since our test infra does that for us. Removing them everywhere would be a
nice separate PR.
##########
solr/core/src/test/org/apache/solr/security/BasicAuthStandaloneTest.java:
##########
@@ -54,8 +53,6 @@ public class BasicAuthStandaloneTest extends SolrTestCaseJ4 {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
private static final Path ROOT_DIR = TEST_HOME();
- private static final Path CONF_DIR =
- ROOT_DIR.resolve("configsets").resolve("configset-2").resolve("conf");
Review Comment:
It appears you've changed this test to no longer use configset-2. Why?
##########
solr/core/src/test/org/apache/solr/handler/ReplicationTestHelper.java:
##########
@@ -62,14 +61,9 @@ public final class ReplicationTestHelper {
+ FileSystems.getDefault().getSeparator();
public static JettySolrRunner createAndStartJetty(SolrInstance instance)
throws Exception {
- Files.copy(
- SolrTestCaseJ4.TEST_HOME().resolve("solr.xml"),
- Path.of(instance.getHomeDir(), "solr.xml"),
- StandardCopyOption.REPLACE_EXISTING);
- Properties nodeProperties = new Properties();
- nodeProperties.setProperty("solr.data.dir", instance.getDataDir());
Review Comment:
I guess generally you have identified that setting solr.data.dir isn't
necessary?
##########
solr/core/src/test/org/apache/solr/handler/V2StandaloneTest.java:
##########
@@ -35,7 +34,6 @@ public void testWelcomeMessage() throws Exception {
Path solrHomeTmp = createTempDir();
PathUtils.copyDirectory(
TEST_HOME().resolve("configsets/minimal/conf"),
solrHomeTmp.resolve("conf"));
- Files.copy(TEST_HOME().resolve("solr.xml"),
solrHomeTmp.resolve("solr.xml"));
Review Comment:
So why is solr.xml copying no longer necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
