epugh commented on code in PR #3955:
URL: https://github.com/apache/solr/pull/3955#discussion_r2632674156
##########
solr/core/src/java/org/apache/solr/cli/StatusTool.java:
##########
@@ -292,42 +291,26 @@ public Map<String, Object> waitToSeeSolrUp(
public Map<String, Object> getStatus(String solrUrl, String credentials)
throws Exception {
try (var solrClient = CLIUtils.getSolrClient(solrUrl, credentials)) {
- return getStatus(solrClient);
+ Map<String, Object> status = reportStatus(solrClient);
+ return status;
}
}
- public Map<String, Object> getStatus(SolrClient solrClient) throws Exception
{
- Map<String, Object> status;
-
- NamedList<Object> systemInfo =
- solrClient.request(
- new GenericSolrRequest(SolrRequest.METHOD.GET,
CommonParams.SYSTEM_INFO_PATH));
- // convert raw JSON into user-friendly output
- status = reportStatus(systemInfo, solrClient);
-
- return status;
- }
-
- public static Map<String, Object> reportStatus(NamedList<Object> info,
SolrClient solrClient)
- throws Exception {
+ public static Map<String, Object> reportStatus(SolrClient solrClient) throws
Exception {
Map<String, Object> status = new LinkedHashMap<>();
Review Comment:
makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
