igiguere commented on code in PR #3955:
URL: https://github.com/apache/solr/pull/3955#discussion_r2631504026
##########
solr/core/src/test/org/apache/solr/handler/admin/AdminHandlersProxyTest.java:
##########
@@ -91,13 +81,8 @@ public void proxySystemInfoHandlerOneNode() {
nodes.forEach(
node -> {
MapSolrParams params = new
MapSolrParams(Collections.singletonMap("nodes", node));
- GenericSolrRequest req =
- new GenericSolrRequest(
- SolrRequest.METHOD.GET,
- "/admin/info/system",
- SolrRequest.SolrRequestType.ADMIN,
- params);
- SimpleSolrResponse rsp = null;
+ SystemInfoRequest req = new SystemInfoRequest(params);
+ SystemInfoResponse rsp = null;
Review Comment:
It was like that already, but for SimpleSolrResponse. I'll remove the `=
null`.
******************
Update: It was initialized to avoid compile error at line 91, after the
try-catch, when rsp is used: "variable rsp might not have been initialized".
So I'll move the following asserts into the try-catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
