igiguere commented on code in PR #3955: URL: https://github.com/apache/solr/pull/3955#discussion_r2632023012
########## solr/solrj/src/java/org/apache/solr/client/solrj/response/SystemInfoResponse.java: ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.client.solrj.response; + +import java.lang.invoke.MethodHandles; +import java.util.Date; +import org.apache.solr.client.solrj.request.json.JacksonContentWriter; +import org.apache.solr.common.util.NamedList; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** This class holds the response from V1 "/admin/info/system" or V2 "/node/system" */ +public class SystemInfoResponse extends SolrResponseBase { + + private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); + + private static final long serialVersionUID = 1L; + + private org.apache.solr.client.api.model.SystemInfoResponse fullResponse; Review Comment: In org.apache.solr.client.api.*: Most API model classes that represent responses have a name in *Reponse. There's also some *RequestBody. There seems to be some mapping between the class name and the exposed resource path (but not 100%) So I think the system info response should have a name that ends in *Response. And I like the idea of keeping names aligned ("/whatever" resource = WhateverAPI -> WhateverResponse) The "home-grown" V2 NodeSystemInfoAPI exposes resource path "/node/system". Presumably, the JAX-RS V2 would still have a class name similar to it's resource path (i.e.: NodeSystemAPI ?) ... Which would make the API model class NodeSystemResponse ? That's my 2 cents. @epugh, @gerlowskija I have changes ready to address Eric's comments, but I'll wait for consensus on this class name before I commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
