epugh commented on code in PR #3920:
URL: https://github.com/apache/solr/pull/3920#discussion_r2626581317
##########
solr/test-framework/src/java/org/apache/solr/util/SolrClientTestRule.java:
##########
@@ -85,11 +84,6 @@ public NewCollectionBuilder withConfigSet(String configSet) {
return this;
}
- public NewCollectionBuilder withConfigFile(String configFile) {
Review Comment:
I'm going to back the removed code out in the interest of moving forward. I
do think it's interesting that none of the existing tests provide a custom
solrconfig.xml. HOwever, maybe when we finish migrating to using
`SolrClientTestRule` the use or non-use of solrconfig.xml will become more
apparent!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
