epugh commented on code in PR #3920:
URL: https://github.com/apache/solr/pull/3920#discussion_r2588750417
##########
solr/test-framework/src/java/org/apache/solr/util/SolrClientTestRule.java:
##########
@@ -85,11 +84,6 @@ public NewCollectionBuilder withConfigSet(String configSet) {
return this;
}
- public NewCollectionBuilder withConfigFile(String configFile) {
Review Comment:
So, I think this is the specific feedback that I'm looking for... should we
keep methods that aren't used by Solr in the test-framework? My default is to
remove code that isn't used by SOlr actively under the theory that fewer lines
of code reduces tech burden and makes it easier to understand these classes for
both me and any one else who is new to Solr.. More code is harder. Your
comment though gets to the crux, should I keep the methods in test framework
that aren't used like these builders on the theory that others MIGHT be calling
them. And maybe, if they are more complex than getter/setter, we should up the
test coverage that we have for them in the `test-framework/src/test/` tree...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
