dsmiley commented on code in PR #3920:
URL: https://github.com/apache/solr/pull/3920#discussion_r2589183175
##########
solr/test-framework/src/java/org/apache/solr/util/SolrClientTestRule.java:
##########
@@ -85,11 +84,6 @@ public NewCollectionBuilder withConfigSet(String configSet) {
return this;
}
- public NewCollectionBuilder withConfigFile(String configFile) {
Review Comment:
BTW, thanks for drawing attention to some of the removals in the PR comment!
It's a murky area that will be subjective; I don't think I can articulate
guidance/recommendation. I will review them and comment on any that I suggest
that you keep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
