dsmiley commented on code in PR #3885:
URL: https://github.com/apache/solr/pull/3885#discussion_r2578367734
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -381,112 +373,10 @@ public void setAuthenticationStore(AuthenticationStore
authenticationStore) {
}
/** (visible for testing) */
- public long getIdleTimeout() {
+ public long getIdleTimeoutMillis() {
Review Comment:
Did you notice the `(visible for testing)` comment? It's used in tests,
and, granted, one of our builders too. I suspect **if** someone is calling it,
they will very quickly observe the needed correction, with or without any
change notes mentioning this obscure getter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
