dsmiley commented on code in PR #3885:
URL: https://github.com/apache/solr/pull/3885#discussion_r2560100166
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateHttp2SolrClient.java:
##########
@@ -47,29 +48,31 @@
import org.slf4j.LoggerFactory;
import org.slf4j.MDC;
-/** A Solr client using {@link Http2SolrClient} to send concurrent updates to
Solr. */
-public class ConcurrentUpdateHttp2SolrClient extends SolrClient {
+/** A ConcurrentUpdate {@link SolrClient} -- it sends updates concurrently and
asynchronously. */
+public abstract class ConcurrentUpdateHttp2SolrClient extends SolrClient {
+ // nocommit rename to ConcurrentUpdateBaseSolrClient or
ConcurrentUpdateSolrClientBase
Review Comment:
Thoughts @jdyer1 @gerlowskija ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
