dsmiley commented on code in PR #3885:
URL: https://github.com/apache/solr/pull/3885#discussion_r2558401790
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateHttp2SolrClient.java:
##########
@@ -177,7 +186,7 @@ protected ConcurrentUpdateHttp2SolrClient(Builder builder) {
}
/** Class representing an UpdateRequest and an optional collection. */
- private record Update(UpdateRequest request, String collection) {}
+ protected record Update(UpdateRequest request, String collection) {}
Review Comment:
We can now use non-private Java records! CC @iamsanjay , in some other PR I
at-mentioned you that it wasn't working. Claude found the fix pretty darned
quick :-) -- we have some missing javadocs doclet custom thing that needed an
extra case statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
