dsmiley commented on code in PR #3851:
URL: https://github.com/apache/solr/pull/3851#discussion_r2527403003


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##########
@@ -117,7 +119,12 @@ public abstract class CloudSolrClient extends SolrClient {
           // UpdateParams.ROLLBACK
           );
 
-  protected volatile Object[] locks = objectList(3);
+  private final ConcurrentHashMap<String, CompletableFuture<DocCollection>> 
collectionRefreshes =
+      new ConcurrentHashMap<>();
+  private final Object stateRefreshExecutorLock = new Object();
+  private volatile int stateRefreshParallelism = 
DEFAULT_STATE_REFRESH_PARALLELISM;
+  private volatile ExecutorService stateRefreshExecutor;

Review Comment:
   I know my audience (you), and figured you would be receptive.  As you 
followed my recommendation and obviously knew why I was recommend this, I was 
right.  Sorry if it rubbed you the wrong way, and thanks for being receptive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to