markrmiller commented on PR #3851: URL: https://github.com/apache/solr/pull/3851#issuecomment-3530832994
Addressed @dsmiley’s inline notes: reused the existing update thread pool with a semaphore for refreshes, added javadocs for markMaybeStaleIfOutsideBackoff, switched the refresh cleanup to whenCompleteAsync so we don’t mutate the map inside compute, documented why we temporarily drop _stateVer_, and tagged the waitedForRefresh parameter. Let me know if you’d still like the in-flight refresh tracker folded directly into StateCache; right now it’s only tracking outstanding futures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
