markrmiller commented on code in PR #3851:
URL: https://github.com/apache/solr/pull/3851#discussion_r2525743387
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##########
@@ -195,14 +206,39 @@ boolean shouldRetry() {
void setRetriedAt() {
retriedAtNano = System.nanoTime();
}
+
+ boolean markMaybeStaleIfOutsideBackoff(long retryBackoffNano) {
Review Comment:
This type of comment has similar deficiencies. There is no concrete reason
why you suggest this. It’s framed as a drive-by suggestion, not a joint attempt
to clarify the API. That makes it easy to dismiss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
