dsmiley commented on code in PR #3684:
URL: https://github.com/apache/solr/pull/3684#discussion_r2427617422
##########
solr/solrj/src/java/org/apache/solr/common/params/CollectionParams.java:
##########
@@ -111,8 +111,8 @@ enum CollectionAction {
DISTRIBUTEDAPIPROCESSING(false, LockLevel.NONE),
LIST(false, LockLevel.NONE),
CLUSTERSTATUS(false, LockLevel.NONE),
- ADDREPLICAPROP(true, LockLevel.REPLICA),
- DELETEREPLICAPROP(true, LockLevel.REPLICA),
+ ADDREPLICAPROP(true, LockLevel.NONE), // nocommit discuss
+ DELETEREPLICAPROP(true, LockLevel.NONE), // nocommit discuss
Review Comment:
Discussed in dev list. I'm inclined to have these be NONE. And add an
upgrade ref guide note about BALANCESHARDSUNIQUE to advise not to change the
property during running that command (duh).
For that matter... no reason not to do likewise for manipulating a
collection property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
