dsmiley commented on code in PR #3684:
URL: https://github.com/apache/solr/pull/3684#discussion_r2427627636
##########
solr/core/src/test/org/apache/solr/cloud/TestLockTree.java:
##########
@@ -82,7 +82,7 @@ public void testLocks() throws Exception {
List<Thread> threads = new ArrayList<>();
for (Pair<CollectionAction, List<String>> operation : operations) {
final Lock lock = session.lock(operation.first(), operation.second());
- if (lock != null) {
+ if (lock != null && !lock.equals(LockTree.FREELOCK)) {
Review Comment:
curious what's going on here? (and with orderOfExecutionChanges)
##########
solr/core/src/test/org/apache/solr/cloud/TestLockTree.java:
##########
@@ -48,7 +48,7 @@ public void testLocks() throws Exception {
.getSession()
.lock(CollectionAction.BALANCESHARDUNIQUE, Arrays.asList("coll1",
"shard1")));
- assertNull(
+ assertNotNull(
Review Comment:
shouldn't we be unlocking the lock we got?
I'm also a bit surprised that the API would return a lock at all when
LockLevel is none for this command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
