dsmiley commented on code in PR #3684:
URL: https://github.com/apache/solr/pull/3684#discussion_r2377582861
##########
solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc:
##########
Review Comment:
As we want waitForFinalState to disappear, why continue to document it? I
say remove it from the ref guide.
##########
solr/CHANGES.txt:
##########
@@ -236,6 +236,8 @@ Other Changes
overseerEnabled cluster property and an env var SOLR_CLOUD_OVERSEER_ENABLED.
Read more in the
upgrade guide. (David Smiley)
+* SOLR-17712: Changing default behaviour of `waitForFinalState` while handling
the collection creation and collection management to true and is now
deprecated. (Abhishek Umarjikar)
Review Comment:
I think this goes in the improvement category.
##########
solr/api/src/java/org/apache/solr/client/api/model/BalanceReplicasRequestBody.java:
##########
Review Comment:
in the API module (a V2) thing), waitForFinalState should no longer be
present (shouldn't be part of the surface API).
##########
solr/CHANGES.txt:
##########
@@ -236,6 +236,8 @@ Other Changes
overseerEnabled cluster property and an env var SOLR_CLOUD_OVERSEER_ENABLED.
Read more in the
upgrade guide. (David Smiley)
+* SOLR-17712: Changing default behaviour of `waitForFinalState` while handling
the collection creation and collection management to true and is now
deprecated. (Abhishek Umarjikar)
Review Comment:
```suggestion
* SOLR-17712: SolrCloud admin commands should more reliably be fully
completed when Solr returns a response.
The `waitForFinalState` param now defaults to true and is deprecated.
(Abhishek Umarjikar)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
