mlbiscoc commented on PR #3671:
URL: https://github.com/apache/solr/pull/3671#issuecomment-3334801256
It was definitely worth exploring. I played around with it thought about it
more and after looking I think I prefer it as an attribute and probably against
prefixing it in the name. I am not really worried about cardinality but labels
also help with filtering not just aggregation. So at something like the OTel
collector level you can filter more easily or if we improve that on the
/admin/metrics endpoint and at promQL it can be more annoying to aggregate like
`solr_*Cache_lookups` as a filter parameter for caches. Also to pick up new
caches you need to change your dashboards since its embedded in the name
(though I know you argued changing or removing caches isn't done often) but
with labels nothing needs to change. Also the naming doesn't follow our snake
case convention which looks awkward. If we care about a user knowing its cache
level or component, then maybe that should be an attribute as well `level` or
`component` = `searcher/node/foobar`. Something that could be nice thou
gh from this is that someone could pass in their own description for each
cache since it created it own metric.
```
# HELP solr_searcher_fieldValueCache_lookups_total Number of cumulative
cache lookup results (hits and misses)
# TYPE solr_searcher_fieldValueCache_lookups_total counter
solr_searcher_fieldValueCache_lookups_total{category="CACHE",collection="demo",core="demo_shard1_replica_n1",otel_scope_name="org.apache.solr",replica="replica_n1",result="hit",shard="shard1"}
0.0
solr_searcher_fieldValueCache_lookups_total{category="CACHE",collection="demo",core="demo_shard1_replica_n1",otel_scope_name="org.apache.solr",replica="replica_n1",result="miss",shard="shard1"}
0.0
solr_searcher_fieldValueCache_lookups_total{category="CACHE",collection="foobar",core="foobar_shard1_replica_n1",otel_scope_name="org.apache.solr",replica="replica_n1",result="hit",shard="shard1"}
0.0
solr_searcher_fieldValueCache_lookups_total{category="CACHE",collection="foobar",core="foobar_shard1_replica_n1",otel_scope_name="org.apache.solr",replica="replica_n1",result="miss",shard="shard1"}
0.0
# HELP solr_searcher_documentCache_lookups_total Number of cumulative cache
lookup results (hits and misses)
# TYPE solr_searcher_documentCache_lookups_total counter
solr_searcher_documentCache_lookups_total{category="CACHE",collection="demo",core="demo_shard1_replica_n1",otel_scope_name="org.apache.solr",replica="replica_n1",result="hit",shard="shard1"}
0.0
solr_searcher_documentCache_lookups_total{category="CACHE",collection="demo",core="demo_shard1_replica_n1",otel_scope_name="org.apache.solr",replica="replica_n1",result="miss",shard="shard1"}
0.0
solr_searcher_documentCache_lookups_total{category="CACHE",collection="foobar",core="foobar_shard1_replica_n1",otel_scope_name="org.apache.solr",replica="replica_n1",result="hit",shard="shard1"}
0.0
solr_searcher_documentCache_lookups_total{category="CACHE",collection="foobar",core="foobar_shard1_replica_n1",otel_scope_name="org.apache.solr",replica="replica_n1",result="miss",shard="shard1"}
0.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
