mlbiscoc commented on PR #3671: URL: https://github.com/apache/solr/pull/3671#issuecomment-3324124441
> Since we should prefer aggregations outside of the service we export, shouldn't we omit the hit ratio? Good point. Will remove it. The same metrics exist to calculate it yourself. > This metric looks useless: solr_cache_ops_total So you want to remove it? It is used in many different tests. > FWIW w export some metrics as gauges but Gemini AI pointed out that some of these look like counters, and that counters allow use of PromQL functions like rate() and increase(), implying it's impossible otherwise. I believe you technically can use functions like `rate()` and `increase()` for gauges but shouldn't because those functions were created for counters (Strictly increasing numbers). If gauges goes down at any point, the function outputs misleading data. But at that point if your gauge never goes down, it should have been a counter in the first place. I tried my best to make things counters when we can but possible I missed some places so let me know if you see something. For this PR specifically, I noticed now in the PR the `solr_cache_cumulative_lookups` should be the counter and `solr_cache_lookups` should be a gauge since it can get reset to 0 on cache warm (I flipped it) . Going to fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
