dsmiley commented on code in PR #3270:
URL: https://github.com/apache/solr/pull/3270#discussion_r2008132446
##########
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##########
@@ -240,9 +241,9 @@ public RequestWriter.ContentWriter getContentWriter(String
expectedType) {
/**
* Create a new SolrResponse to hold the response from the server
*
- * @param client the {@link SolrClient} the request will be sent to
+ * @param namedList the {@link SolrClient} the request will be sent to
*/
- protected abstract T createResponse(SolrClient client);
+ protected abstract T createResponse(NamedList<Object> namedList);
Review Comment:
RE NamedList: this PR technically adds an API endpoint (for those that would
create custom requests), but it sort of removes another, albeit not actually
:-). `SolrResponse.setResponse(NamedList)` is the existing spot that populates
the response. This PR instead _suggests_ constructor based population, which
is what will happen for the V2 side and any other API we (or a user) makes to
leverage a response that is not SolrResponse based. I'm choosing to leave
`SolrResponse.setResponse(NamedList)` as-is because it doesn't seem worth
disturbing it. It's not the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
