gerlowskija commented on code in PR #3270:
URL: https://github.com/apache/solr/pull/3270#discussion_r2007952602
##########
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##########
@@ -240,9 +241,9 @@ public RequestWriter.ContentWriter getContentWriter(String
expectedType) {
/**
* Create a new SolrResponse to hold the response from the server
*
- * @param client the {@link SolrClient} the request will be sent to
+ * @param namedList the {@link SolrClient} the request will be sent to
*/
- protected abstract T createResponse(SolrClient client);
+ protected abstract T createResponse(NamedList<Object> namedList);
Review Comment:
> I could change the V1 APIs to use it; it'd increase the scope of this PR a
good deal but for the better
If you want to, great. But don't expand the scope that much on my account!
Your answer is plenty explanation for my sake.
> Right; no impl uses it yet; the V2 API certainly will
Dang, don't love the irony of the v2 API being the main cause of a new
NamedList usage.
It'd be really awesome if this could take the entire `InputStream`, and have
Jackson parse directly from that rather than use the NamedList intermediary.
But I guess that's not possible because `process` calls `request` which needs
to return a NL in turn.... *sigh*
Ignore me, just thinking aloud here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
