dsmiley commented on PR #3270: URL: https://github.com/apache/solr/pull/3270#issuecomment-2741817502
I added some SolrRequest javadocs for clarification; I think you'll like it. I ultimately didn't customize any createResponse implementation because we universally use V1 SolrResponse, which has it's setResponse(NamedList) called, which means attempting to customize will result in the response being set twice. I was tempted to change in V2 but that quickly snowballs the scope creep which I want to avoid. Again, I'll show something later to show it works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
