[ 
https://issues.apache.org/jira/browse/SOLR-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933690#comment-17933690
 ] 

ASF subversion and git services commented on SOLR-17623:
--------------------------------------------------------

Commit 046677d10b384dd399da53b89d19ab457ab5e6b1 in solr's branch 
refs/heads/deprecations from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=046677d10b3 ]

SOLR-17623: SimpleOrderedMap equals, hashCode (and for Map.Entry) (#3214)

And ensure a NamedList is never equal to a SimpleOrderedMap

> SimpleOrderedMap should implement Map
> -------------------------------------
>
>                 Key: SOLR-17623
>                 URL: https://issues.apache.org/jira/browse/SOLR-17623
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Priority: Major
>              Labels: newdev, pull-request-available
>             Fix For: 9.9
>
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> SimpleOrderedMap is semantically a Map; it should implement Map.  
> Why: This will help us transition away from NamedList (it's superclass) in a 
> number of places, since many (most?) places that are defined to return a 
> NamedList could actually be declared to be a SimpleOrderedMap and eventually 
> simply Map.  
> There's some risk that code somewhere gets this Map, a large one, and then 
> assumes it has better than O(N) lookup, which it doesn't provide.  Perhaps a 
> Javadoc warning will do.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to