[ 
https://issues.apache.org/jira/browse/SOLR-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914218#comment-17914218
 ] 

David Smiley commented on SOLR-17623:
-------------------------------------

Okay; implement put, etc.  See NamedList.asShallowMap for some code to borrow, 
at least partially.

The scope of this issue/PR should be fairly limited though, _mostly_ scoped to 
this class.  It's not a codebase wide transformation.

> SimpleOrderedMap should implement Map
> -------------------------------------
>
>                 Key: SOLR-17623
>                 URL: https://issues.apache.org/jira/browse/SOLR-17623
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Priority: Major
>              Labels: newdev
>
> SimpleOrderedMap is semantically a Map; it should implement Map.  
> Why: This will help us transition away from NamedList (it's superclass) in a 
> number of places, since many (most?) places that are defined to return a 
> NamedList could actually be declared to be a SimpleOrderedMap and eventually 
> simply Map.  
> There's some risk that code somewhere gets this Map, a large one, and then 
> assumes it has better than O(N) lookup, which it doesn't provide.  Perhaps a 
> Javadoc warning will do.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to