dsmiley commented on code in PR #2899:
URL: https://github.com/apache/solr/pull/2899#discussion_r1885757147
##########
solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java:
##########
Review Comment:
WDYT @iamsanjay ?
##########
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java:
##########
@@ -305,16 +306,16 @@ public void init(PluginInfo info) {
sb);
int soTimeout =
getParameter(args, HttpClientUtil.PROP_SO_TIMEOUT,
HttpClientUtil.DEFAULT_SO_TIMEOUT, sb);
-
- this.defaultClient =
+ this.httpClientBuilder =
new Http2SolrClient.Builder()
.withConnectionTimeout(connectionTimeout, TimeUnit.MILLISECONDS)
.withIdleTimeout(soTimeout, TimeUnit.MILLISECONDS)
.withExecutor(commExecutor)
.withMaxConnectionsPerHost(maxConnectionsPerHost)
- .build();
- this.defaultClient.addListenerFactory(this.httpListenerFactory);
- this.loadbalancer = new
LBHttp2SolrClient.Builder<Http2SolrClient>(defaultClient).build();
+ .withListenerFactory(List.of(this.httpListenerFactory));
Review Comment:
I noticed an issue. This overwrites the list of listeners that may already
be present. Shouldn't we be augmenting, not replacing?
##########
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java:
##########
@@ -305,16 +306,16 @@ public void init(PluginInfo info) {
sb);
int soTimeout =
getParameter(args, HttpClientUtil.PROP_SO_TIMEOUT,
HttpClientUtil.DEFAULT_SO_TIMEOUT, sb);
-
- this.defaultClient =
+ this.httpClientBuilder =
Review Comment:
please name `httpSolrClientBuilder` -- so as to clarify this isn't an
Apache/Jetty HttpClient; it's a SolrClient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
