jdyer1 commented on PR #2899: URL: https://github.com/apache/solr/pull/2899#issuecomment-2539449326
> your conversion of passing the Builder as a template instead of an existing client should switch back to the client as a template I am not sure this ticket/PR has much value if we continue having the caller pass in a pre-built delegate client instead of a Builder. `LBHttp2solrClient` needs to create a client per base url, but the caller only supplies one. Yet `LBHttp2SolrClient`might not know how to correctly clone that client, keeping in mind `LBHttp2solrClient` is now generic. It seems to me that passing in the pre-built client is more of a relic of the days before we used Bulders in solrJ, and not a really great API decision. I was hoping to improve that here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
