gus-asf commented on PR #2585: URL: https://github.com/apache/solr/pull/2585#issuecomment-2253177359
Ah interesting question. Reminds me of something I said years ago. We are quite tightly bound to ZK for our coordination needs. This might be an opportunity to introduce an interface that is supplier agnostic (CollectionPropertiesManager) with an implementation as above. Then apply that interface to ZkStateReader to ease transition, At a later date when more things have appropriate interfaces, it might be possible to have implementations back-ended by: - External ZK - Embedded ZK - etcd - nextNewHotnessCoordinationd We would want to think about the way one acquires implementations of course. And maybe that bit is a later PR... Perhaps some such interfaces could live in org.apache.solr.cluster.coordination in solrj if they have user-useful aspects? But overall I guess the main answer to your actual question is that I think implementations should be hidden and if possible interfaces exposed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
