dsmiley commented on PR #2585: URL: https://github.com/apache/solr/pull/2585#issuecomment-2253046055
Because ZkStateReader has no getter for CollectionPropertiesZkStateReader, in fact callers must continue to use ZkStateReader. There isn't anything necessarily wrong with that but then CollectionPropertiesZkStateReader should probably not be public and it's helpful long javadocs on the methods should return to ZkStateReader since code will continue to call those methods. WDYT @gus-asf ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
