dsmiley commented on code in PR #2585:
URL: https://github.com/apache/solr/pull/2585#discussion_r1692105944
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##########
@@ -207,6 +207,10 @@ public static ZkStateReader from(CloudSolrClient
solrClient) {
}
}
+ protected ExecutorService getNotifications(){
Review Comment:
It doesn't return notifications, it returns an Executor to deliver
asynchronous notifications on. I suggest the name getWatcherExecutor or
getNotificationExecutor. Maybe the "Watcher" name because the thread pool is
named this, thus that's how this executor is visible. Anyway, no big deal.
BTW I can see you are forgetting to run "tidy".
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java:
##########
@@ -50,17 +50,14 @@ public class CollectionPropertiesZkStateReader implements
Closeable {
* notified when the properties of the collection change. When a
collection's properties change,
* all registered observers for that collection are notified by a
"collectionPropWatcher".
*/
- private ConcurrentHashMap<String, CollectionWatch<CollectionPropsWatcher>>
+ private final ConcurrentHashMap<String,
CollectionWatch<CollectionPropsWatcher>>
collectionPropsObservers = new ConcurrentHashMap<>();
/** Used to submit notifications to Collection Properties watchers in order
*/
private final ExecutorService collectionPropsNotifications =
ExecutorUtil.newMDCAwareSingleThreadExecutor(
new SolrNamedThreadFactory("collectionPropsNotifications"));
- private final ExecutorService notifications =
Review Comment:
I realize I was mistaken that it's used for multiple things, so your choice
of separating it to a "cache cleaner" one is reasonable. I like the way you
had it in retrospect... but don't care enough either way so do as you like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
