laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1576965590
########## solr/core/src/test/org/apache/solr/cloud/SolrCLIZkUtilsTest.java: ########## @@ -69,6 +70,7 @@ public static void closeConn() { zkClient = null; } zkAddr = null; + System.clearProperty("solr.solr.home"); Review Comment: Yeah I was hesitating on doing it this way but ended up following the existing "style". But I think we don't need this as we can rely on _SystemPropertiesRestoreRule_. Will test and let you know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org