sigram commented on code in PR #2244: URL: https://github.com/apache/solr/pull/2244#discussion_r1489775946
########## solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java: ########## @@ -622,8 +622,8 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw } while (nextStage != Integer.MAX_VALUE); if (publishCpuTime) { - rsp.getResponseHeader().add(ThreadStats.CPU_TIME, totalShardCpuTime); - rsp.addToLog(ThreadStats.CPU_TIME, totalShardCpuTime); + rsp.getResponseHeader().add(ThreadCpuTime.CPU_TIME, totalShardCpuTime); Review Comment: This can never be null due to the assignment that depends on the same condition in the if() around line 221. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org