sigram commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489156800
##########
solr/core/src/java/org/apache/solr/search/QueryLimits.java:
##########
@@ -41,11 +43,15 @@ private QueryLimits() {}
* statement will hinge on hasXXXLimit() static method attached to the
implementation class.
*
* @param req the current SolrQueryRequest.
+ * @param threadCpuTime current thread CPU time monitor.
*/
- public QueryLimits(SolrQueryRequest req) {
+ public QueryLimits(SolrQueryRequest req, ThreadCpuTime threadCpuTime) {
if (hasTimeLimit(req)) {
limits.add(new SolrQueryTimeLimit(req));
}
+ if (hasCpuLimit(req)) {
+ limits.add(new CpuQueryTimeLimit(req, threadCpuTime));
Review Comment:
It's still not too late to rename the whole family, for example:
* `SolrQueryTimeLimit` -> `TimeAllowedLimit`
* `CpuQueryTimeLimit` -> `CpuAllowedLimit`
* `MemQueryLimit` -> `MemAllowedLimit`
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
