sigram commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489762243


##########
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##########
@@ -76,7 +77,7 @@ public abstract class RequestHandlerBase
 
   private PluginInfo pluginInfo;
 
-  protected boolean publishCpuTime = 
Boolean.getBoolean(ThreadStats.ENABLE_CPU_TIME);
+  protected boolean publishCpuTime = 
Boolean.getBoolean(ThreadCpuTime.ENABLE_CPU_TIME);

Review Comment:
   They are not. It's true that `ThreadCpuTimer` will be created on first call 
to `SolrRequestInfo.getThreadCpuTimer()`, whoever first calls it (either due to 
this sysprop being true, or due to the `cpuAllowed` query param). However, 
after that the logging will happen only if the sysprop is true, again 
regardless of the `cpuAllowed` query param, and the limiting will happen 
regardless of the logging sysprop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to