epugh commented on PR #2177: URL: https://github.com/apache/solr/pull/2177#issuecomment-1883191148
I am having a bit of heart burn on the term "DataStore".... The more I see it proliferate the more it just seems like a bit of classic Enterprise Java type naming that doesn't mean anything... I do see in our codebase `ExpressionType.DATASTORE` is used in streaming expressions that refers to "Solr/Lucene" as a source of data. It is also used to refer to a JDBC DataStore as well in our codebase. Both of those represent Data Stores in the traditional generic fashion. And don't imply a search index or other Solr specific concept. As I write this, I come back to why can't we just stick with Collection? Reading the ref guide glossary again, the definition of `Collection` is `In Solr, one or more [Documents](https://solr.apache.org/guide/solr/latest/getting-started/solr-glossary.html#document) grouped together in a single logical index using a single configuration and Schema.`. Yes, it also says `Single-node installations and user-managed clusters use instead the concept of a [Core](https://solr.apache.org/guide/solr/latest/getting-started/solr-glossary.html#core).`. Maybe we rework this definition to be ``` Single-node installations and user-managed clusters also have the concept of a [Core](https://solr.apache.org/guide/solr/latest/getting-started/solr-glossary.html#core) being synonymous with a Collection. ``` Let's move forward with the concept of Collection representing a logical index regardless of the physical details.... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org