gerlowskija commented on code in PR #2177:
URL: https://github.com/apache/solr/pull/2177#discussion_r1442460595
##########
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##########
@@ -175,6 +175,19 @@ public void setQueryParams(Set<String> queryParams) {
public abstract SolrParams getParams();
+ /**
+ * Determines whether this request should use or ignore any specified data
stores (esp. {@link
+ * SolrClient#defaultCollection})
+ *
+ * <p>Many Solr requests target a particular data store (i.e. core or
collection). But not all of
+ * them - many Solr APIs (e.g. security or other admin APIs) are agnostic of
data stores entirely.
+ * This method gives these requests a way to opt out of using {@link
SolrClient#defaultCollection}
+ * or other specified data stores.
+ */
+ public boolean requiresDataStore() {
Review Comment:
[Q] I've used the term "Data Store" here as a generic way to refer to either
a core or collection name.
There's some precedent for that term already (see discussion
[here](https://github.com/apache/solr/pull/1978#issuecomment-1747451445)), but
I figured I'd flag it again in case anyone missed that earlier discussion. The
choice of terminology hasn't spread very far yet, and we could probably still
change it if anyone has huge objections. But absent any serious concerns, I'm
going to stick with it since there is precedent...
(Now that I think about it, maybe the variable names and builder methods
should also use the "data store" term, e.g.
`SolrClientBuilder.withDefaultDataStore(..)`...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
