dsmiley commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1843798621
We can still move metrics initialization to later in addition to other ideas here. I think it belongs later conceptually. `initPlugins(CircuitBreaker)` would move later as well (there's a comment saying it needs to follow metric initialization). Maybe another line of attack is to replace this ugly hack/trick: https://github.com/apache/solr/blob/195d18223f797824e0867101490358861cc1b978/solr/core/src/java/org/apache/solr/core/SolrCore.java#L1165-L1172 Instead, we could grab the `openSearcherLock` (thus blocking use of that executor) and unlock it about the time we countDown on "latch". Come to think of it, we don't need "CountDownLatch", we can just use openSearcherLock instead -- the "latch" exists only in relation to the searcher, after all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
