stillalex commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1843400180
> I was also thinking about whether that could be moved further down. I don't think that will help. there are some async things happening so simply moving the code would not provide a stronger guarantee. > I'm wondering if we can delay initializeMetrics until the SolrCore constructor finishes. delaying the metrics was what I was going for. but would we need to delay all metrics or just the problematic ones? there is a 'latch' object that hints to provide some safety against events firing too early but I could not hook into this code due to complexity. https://github.com/apache/solr/pull/2101/files#diff-3bf44f923643744a743460bb0f64301618dd7529a602d945fe2f7f193d4cdde0R1166-R1168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
