ahubold commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1843177371
> Who is calling SolrCore.initializeMetrics? It's hard to tell; it's an override of a base abstraction so is being called generically somewhere. I'm wondering if we can delay initializeMetrics until the SolrCore constructor finishes. It's called directly from the constructor at https://github.com/apache/solr/blob/0056e82a30d6239af4a80726527ca912a5ca3d31/solr/core/src/java/org/apache/solr/core/SolrCore.java#L1113 I was also thinking about whether that could be moved further down. But I don't know much about this code, and if there's a reason for that call at that time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
