janhoy commented on code in PR #1919:
URL: https://github.com/apache/solr/pull/1919#discussion_r1337018213
##########
solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java:
##########
@@ -814,6 +815,7 @@ public Path getInstancePath() {
new Class<?>[] {
// DO NOT ADD THINGS TO THIS LIST -- ESPECIALLY THINGS THAT CAN BE
CREATED DYNAMICALLY
// VIA RUNTIME APIS -- UNTIL CAREFULLY CONSIDERING THE ISSUES
MENTIONED IN SOLR-8311
+ CircuitBreaker.class,
Review Comment:
Any objections to add CircuitBreaker to the list of SolrCoreAware classes?
Solr's home grown IOC sucks but that's what we have...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
