magibney commented on code in PR #1557:
URL: https://github.com/apache/solr/pull/1557#discussion_r1164365068
##########
solr/core/src/java/org/apache/solr/handler/MoreLikeThisHandler.java:
##########
@@ -395,7 +395,7 @@ private BooleanQuery getBoostedQuery(Query mltquery) {
public DocListAndSet getMoreLikeThis(
int id, int start, int rows, List<Query> filters, int flags) throws
IOException {
- Document doc = reader.document(id);
+ Document doc = reader.storedFields().document(id);
Review Comment:
Creation of StoredFields can be pulled into the
`MoreLikeThisHandler.MoreLikeThisHelper` ctor (it's only ever created as a
local variable/instance, so will by definition be thread-safe). Maybe annotate
`MoreLikeThisHandler.MoreLikeThisHelper` class as NotThreadSafe to guard
against accidental future misuse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
