vinayakphegde commented on code in PR #1557:
URL: https://github.com/apache/solr/pull/1557#discussion_r1164121783
##########
solr/core/src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java:
##########
@@ -695,7 +695,7 @@ protected Object doHighlightingByHighlighter(
// Try term vectors, which is faster
// note: offsets are minimally sufficient for this HL.
- final Fields tvFields = schemaField.storeTermOffsets() ?
reader.getTermVectors(docId) : null;
+ final Fields tvFields = schemaField.storeTermOffsets() ?
reader.termVectors().get(docId) : null;
Review Comment:
we can pass `reader.termVectors()`
we are not using any other method of `reader`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
