risdenk commented on code in PR #1557:
URL: https://github.com/apache/solr/pull/1557#discussion_r1162778943
##########
solr/core/src/java/org/apache/solr/handler/admin/IndexSizeEstimator.java:
##########
@@ -388,7 +388,7 @@ private void estimateTermVectors(Map<String, Object>
result) throws IOException
if (liveDocs != null && !liveDocs.get(docId)) {
continue;
}
- Fields termVectors = leafReader.getTermVectors(docId);
+ Fields termVectors = leafReader.termVectors().get(docId);
Review Comment:
`leafReader.termVectors()` should be outside for for loop?
##########
solr/core/src/java/org/apache/solr/handler/admin/IndexSizeEstimator.java:
##########
@@ -612,7 +612,7 @@ private void estimateStoredFields(Map<String, Object>
result) throws IOException
if (liveDocs != null && !liveDocs.get(docId)) {
continue;
}
- leafReader.document(docId, visitor);
+ leafReader.storedFields().document(docId, visitor);
Review Comment:
`leafReader.storedFields()` should be outside the for loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
