epugh commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1113463405
##########
solr/test-framework/src/java/org/apache/solr/util/SolrJettyTestRule.java:
##########
@@ -52,13 +53,18 @@ protected void after() {
try {
jetty.stop();
} catch (Exception e) {
- throw new RuntimeException(e);
+ try {
+ throw new IOException(e);
+ } catch (IOException ex) {
+ throw new RuntimeException(ex);
+ }
}
jetty = null;
}
}
- public void reset() throws Exception {
+ @Deprecated // Prefer not to have this.
Review Comment:
How would we remove these? Is that part of the scope of this PR or it's
own PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
