epugh commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1113147827
##########
solr/core/src/test/org/apache/solr/TestTolerantSearch.java:
##########
@@ -104,10 +104,7 @@ public static void destroyThings() throws Exception {
collection2.close();
collection2 = null;
}
- if (null != jetty) {
- jetty.stop();
- jetty = null;
- }
+ solrClientTestRule.reset();
Review Comment:
i mentally thought that by using a test rule, some of this clean up stuff
would just be handled by us, because it's a rule?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
