epugh commented on PR #1374: URL: https://github.com/apache/solr/pull/1374#issuecomment-1438599202
Really excited to see progress on anything that makes testing simpler! I hope my comments are being asked prematurely, if you aren't quite ready for review. I am somewhat trying to figure out how this makes our lives simpler in testing... (Partly me coming up the curve on TestRule's!)... For example, I expected to see many of the places where we shutdown Jetty to go completely away, as the TestRule would do it? I see a lot of `solrClientTestRule.reset();` however.... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
